Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: parameterized it cases #37

Merged
merged 2 commits into from
Apr 3, 2024
Merged

chore: parameterized it cases #37

merged 2 commits into from
Apr 3, 2024

Conversation

h1alexbel
Copy link
Contributor

@h1alexbel h1alexbel commented Apr 3, 2024

PR-Codex overview

This PR updates JSON files and test cases to include comments and reviews for specific pull requests.

Detailed summary

  • Added comments and reviews to JSON files 311-with-comments.json, 312-with-comments.json, and 313-with-comments.json
  • Updated test cases in JsonCommentsITCase.java and JsonReviewsITCase.java to reflect changes
  • Added a new test case WithCommentsITCase.java for appending comments to reviews
  • Included necessary imports and annotations for test cases in Java files

The following files were skipped due to too many changes: src/test/resources/it/313-reviews.json

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 31.95%. Comparing base (9bf7dc4) to head (f838332).
Report is 1 commits behind head on master.

Files Patch % Lines
...racehub/codereview/action/github/WithComments.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #37      +/-   ##
============================================
+ Coverage     31.63%   31.95%   +0.32%     
  Complexity       10       10              
============================================
  Files             9        9              
  Lines            98       97       -1     
  Branches          2        2              
============================================
  Hits             31       31              
+ Misses           65       64       -1     
  Partials          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h1alexbel h1alexbel merged commit 6da8c85 into master Apr 3, 2024
6 of 7 checks passed
@h1alexbel h1alexbel deleted the chore-it branch April 3, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant