Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#25): ChangesCount, ChangesCountTest #48

Merged
merged 6 commits into from
Apr 8, 2024
Merged

feat(#25): ChangesCount, ChangesCountTest #48

merged 6 commits into from
Apr 8, 2024

Conversation

h1alexbel
Copy link
Contributor

@h1alexbel h1alexbel commented Apr 8, 2024

closes #25


PR-Codex overview

This PR updates the minimum value for coverage ratio in pom.xml, adds a min_lines parameter in action.yml, and introduces a ChangesCount class for calculating changes in pull requests.

Detailed summary

  • Updated minimum coverage ratio in pom.xml
  • Added min_lines parameter in action.yml
  • Introduced ChangesCount class for calculating PR changes

The following files were skipped due to too many changes: src/test/resources/git/tracehub/codereview/action/github/files.json

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 31.85%. Comparing base (be1f738) to head (12c1592).
Report is 3 commits behind head on master.

Files Patch % Lines
...ain/java/git/tracehub/codereview/action/Entry.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #48      +/-   ##
============================================
+ Coverage     31.31%   31.85%   +0.54%     
- Complexity       10       13       +3     
============================================
  Files             9       10       +1     
  Lines            99      113      +14     
  Branches          2        4       +2     
============================================
+ Hits             31       36       +5     
- Misses           66       75       +9     
  Partials          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h1alexbel
Copy link
Contributor Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Apr 8, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 79ea412 into master Apr 8, 2024
7 checks passed
@rultor
Copy link
Collaborator

rultor commented Apr 8, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 3min)

@h1alexbel h1alexbel deleted the 23 branch April 8, 2024 17:31
@h1alexbel
Copy link
Contributor Author

@rultor release, tag is 0.0.12

@rultor
Copy link
Collaborator

rultor commented Apr 8, 2024

@rultor release, tag is 0.0.12

@h1alexbel OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Apr 8, 2024

@rultor release, tag is 0.0.12

@h1alexbel Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entry.java:65-68: Formulate action stoppers. We should...
2 participants