Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type tests #32

Open
chriskrycho opened this issue May 13, 2021 · 0 comments
Open

Add type tests #32

chriskrycho opened this issue May 13, 2021 · 0 comments
Labels
enhancement New feature or request internal

Comments

@chriskrycho
Copy link
Collaborator

Right now there is no infrastructure checking that the public API of this is stable on TypeScript. As of #31, we have the infrastructure in place to do this, and the tests can be small and integrated into the existing test infrastructure, but they're important for guaranteeing the public API is stable as TS ships new versions.
@chriskrycho chriskrycho added enhancement New feature or request internal labels May 13, 2021
chriskrycho added a commit that referenced this issue May 13, 2021
@chriskrycho
Add all TS versions since 3.7 to CI
1cb5d13 
The package was authored against 3.7.5, and continues to work correctly
against the 4.3 nightlies, so it's reasonable to check it against all
the intermediate versions as well. This makes the contract explicit,
even if there is no formal testing of the public API (#32) yet.
@chriskrycho chriskrycho mentioned this issue May 13, 2021
Merged
chriskrycho added a commit that referenced this issue Oct 25, 2021
@chriskrycho
Fix: accept Iterable in TrackedMap and TrackedSet
bed0d1a 
- add constructor overloads to match those from Map and Set
- add both type and runtime tests to verify this works as expected
- convert entire test suite to TS to get type validation in place at
  least to some degree (partially addresses #32)
@chriskrycho chriskrycho mentioned this issue Oct 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request internal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chriskrycho