Add Pituitary gland example function #75
Conversation
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 75.66% 76.30% +0.63%
==========================================
Files 24 26 +2
Lines 2466 2532 +66
==========================================
+ Hits 1866 1932 +66
Misses 600 600
Continue to review full report at Codecov.
|
WolfByttner
changed the title
| @@ -64,14 +64,36 @@ def pituitary_ode(w, t, p): | |||
|
|
|||
| def compute_pituitary_gland_df_from_parameters(downsample_rate, | |||
There was a problem hiding this comment.
Not clear how this is different than pituitary_ode. Can we give it a shorter name?
There was a problem hiding this comment.
We can probably leave out 'compute', and also 'df', since that is the return type. Maybe simulate_pituitary_ode?
| @@ -64,14 +64,36 @@ def pituitary_ode(w, t, p): | |||
|
|
|||
| def compute_pituitary_gland_df_from_parameters(downsample_rate, | |||
There was a problem hiding this comment.
We can probably leave out 'compute', and also 'df', since that is the return type. Maybe simulate_pituitary_ode?
| return df | ||
|
|
||
|
|
||
| def create_latin_hypercube_sampled_pituitary_df(downsample_rate=100, samples=1000): |
There was a problem hiding this comment.
maybe remove df from method name and also create, like lhs_pituitary() or pituitary_lhs(). Also add method docstring with return types eg, -> DataFrame, int.
| # PyTest will not compute coverage correctly for @jit-compiled code. | ||
| # Thus we must explicitly suppress the coverage check. | ||
| @jit | ||
| def pituitary_ode(w, t, p): # pragma: no cover |
There was a problem hiding this comment.
maybe add type hints for return values -> Tuple[float, float, float, float] with from typing import Tuple at the top
|
@WolfByttner I see it's already merged. Please let me know what you think about the suggestions. |
Add Pituitary gland example function
No description provided.