Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime fallback for calculating episode progress #623

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Fix runtime fallback for calculating episode progress #623

merged 3 commits into from
Sep 7, 2023

Conversation

ZelKami
Copy link
Contributor

@ZelKami ZelKami commented Aug 31, 2023

  • Kodi handles episode runtimes in seconds
  • This addon fetches episode runtimes from Trakt as fallback to avoid multiplying the progress percentage with 0
  • Trakt stores and returns runtimes in minutes and this addon did not account for that which led to issues, see Resume issue with tv shows #571
  • This fix converts the Trakt runtime to seconds by multiplying it with 60, which resolves the issue

@razzeee
Copy link
Collaborator

razzeee commented Sep 2, 2023

Hey, sounds good, did you runtime test it?

@razzeee
Copy link
Collaborator

razzeee commented Sep 2, 2023

This also raises the question, if the conversion needs to happen for movies too.

@ZelKami
Copy link
Contributor Author

ZelKami commented Sep 2, 2023

I've only tested it on my Kodi setup.

For movies there seems to be no fallback to the Trakt runtime

@razzeee
Copy link
Collaborator

razzeee commented Sep 4, 2023

Can you rebase this?

@razzeee razzeee merged commit 8f93f7a into trakt:main Sep 7, 2023
2 checks passed
@ZelKami ZelKami deleted the resume-point branch September 9, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants