Update to tuirealm 2.0 #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including related crates, still forcing "tui". Note that tuirealm 1.9.2 is laggy and is not meant to be used directly, this upgrade is only made to ease the tui -> ratatui and 1.x -> 2.x transition.
i have found that around ~20 is a good size when mouse-capture is on to still be responsive but not have too many events.
it is enabled by default and we dont make any use of mouse events, it just spams the events we dont need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to tui-realm 2.0 (and related component crates).
tuirealm 1.9 had been known to be laggy (see #237) and we also had config migration trouble, but now we have config translation in-place without being dependent on tuirealm and they have also fixed all the problems that we had encountered: