Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib::track::Track refactor #379

Merged
merged 10 commits into from
Oct 31, 2024
Merged

lib::track::Track refactor #379

merged 10 commits into from
Oct 31, 2024

Conversation

hasezoey
Copy link
Contributor

This PR mainly refactors Track to store less needed / derivable data, in more details:

  • refactor Track to not store any initial strings which like Unsupported or Unknown and have all consuming places decide how to handle None
  • refactor Track to not store directory, ext, filename, file and only store a single URI|Path (and derive the other values on-demand
  • refactor Track to always require a location, which can either be a Path or Uri

This PR also does:

  • refactor lib::utils::get_parent_folder and all functions using it to use Paths instead of strings (way less back-and-forth)
  • use one single const string for all fallback Unknown Artist|Title strings (because of this there is no more Unsupported? only Unknown Artist|Title or empty for Albums)
  • change the fallback of filename from album to title only

PS: because this PR touches upon the default unknown strings, it kinda messes with new database entries, though i am planning to re-do the database anyway

hasezoey and others added 10 commits October 28, 2024 11:48
@hasezoey
fix(lib::track::new_radio): unset property "directory"
1768e0e 
not relevant in the radio case, duplicate as "file"
@hasezoey
feat(lib::utils::get_parent_folder): change to use Paths instead of s…
6200c17 
…trings

also update all parts using this function to switch over.
This reduces the need to allocate a lot.
@hasezoey
style(lib::track::new): inline "None" values
a92470f
@hasezoey
fix(lib::track::new): dont use a default string for artist & album
3e7e419
@hasezoey
refactor(lib::library_db::track_db): move const "UNKNOWN_" to module
464a194 
and make it public to the whole crate
@hasezoey
refactor: replace almost all instances of "Unknown Artist | Title" wi…
b0d36fc 
…th the same constant
@hasezoey
fix(tui::ui::components::playlist): replace all instances of "Unknown…
6168edf 
… Artist|Title" with same constant

also change to fallback to filename for "title" instead of "artist"
@hasezoey
fix(lib::track::new): dont set a default for "genre"
a128825
@hasezoey
refactor(lib::track::Track): change to only store the location once
3046569 
and all related fields will be got on-demand (ext, directory, name)
@tramhao
Merge branch 'master' into trackRefactor
b52bf54
@tramhao tramhao merged commit 73ea0cf into tramhao:master Oct 31, 2024
3 of 4 checks passed
@hasezoey hasezoey deleted the trackRefactor branch October 31, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hasezoey @tramhao