[MB-10361] Use custom parameters to configure User Class Weights #83
Conversation
locustfiles/all.py
Outdated
| class_options = request.form.getlist("user_classes_option") | ||
| new_classes = [original_user_classes[n] for n in class_options] | ||
| setattr(environment, "user_classes", new_classes) | ||
| environment._remove_user_classes_with_weight_zero() |
There was a problem hiding this comment.
This errors out for me, because it's an internal method I'm guessing? Since you're setting the user_classes above to what was selected, we wouldn't need to set the unselected classes to a weight of zero I'm assuming.
There was a problem hiding this comment.
I think this might be in a different version of locust. It doesn't error out for me, so hopefully the pipenv changes will make it work for you, too
|
One thing I noticed is the stop test button has vanished for me after changing the user classes and status shows stopped after selecting new user classes and them starting up properly.
|
|
I think there is a way to add custom arguments to appear on the initial screen but I have a feeling that is in version 2 and we are still on Locust version 1. Have there been any discussions on upgrading by chance? On first glance I don't see major breaking changes (famous last words). locustio/locust#1881 |
duncan-truss
changed the title
ahobson
changed the title
THAT IS IT! THANK YOU |
I think this new version fixes that problem. At least, it does for me |
* Also update the task definition to override the locustfile if necessary
|
@ahobson, we've pulled this story into our current sprint, but I've just done a diff with master and I think at this point all the relevant changes might have been merged in other branches. Am I correct in that? Or am I missing something? |
@felipe-lee You are right! I forgot we had this as a separate story and I accidentally sneaked it into another PR. Sorry about that |
|
Awesome, no problem. I'll close this and the ticket out then! |
Description
This is an example of how we could use custom weights to allow us to control which tests are run. Setting a user weight to 0 would remove them.
I tested this locally with locust 2.5.0 and it worked for me. I could run a test and then stop it and run with another set of user weights and it worked.