B-20229 refactor fuel pricer

[deandreJones]

B-20229

Summary

Update FRA weekly effective period

Background

the app pulls the diesel prices every day looking for newly published prices
EIA publishes new prices generally every Monday, before this change they would just be effective until the next publication.
This change makes it so that when new diesel prices are published they are only valid from tueday( or the day after they are published0 through the following Monday

to test

1. run make tasks_save_ghc_fuel_price_data to get the latest pricing data for your test
2. create a new move
3. approve move
4. access prime and create a payment request for fuel surcharge
5. login as TIO - review the payment request
6. validate that it selected the correct price based on the actual pickup date being between the effective and End dates in the DB GHC_DIESEL_FUEL_PRICES

• may want to manually enter a few extra rows verify it works and making the actual pickup date land on the effecting and end dates

[cameroncaci]

Could we comment why this is commented?
https://caci-bits.slack.com/archives/C05DX3AG6EL/p1717687099941339

[deandreJones]

golang/go#61229 (comment)

ill add more to the line- but in short-
our (Mac) build is broken for the go linker on the go version we are using- this forces the use of the older linker

[cameroncaci]

After creating a new move as a customer (Origin MacDill AFB FL, destination Patrick SFB FL), logging into officelocal as HAFC GBLOC multirole, selecting to become a service counselor, and then attempting to view and edit orders, I'm encountering errors.

This was encountered on the Chrome browser

[danieljordan-caci]

After creating a new move as a customer (Origin MacDill AFB FL, destination Patrick SFB FL), logging into officelocal as HAFC GBLOC multirole, selecting to become a service counselor, and then attempting to view and edit orders, I'm encountering errors.

This was encountered on the Chrome browser

I ran through the same scenario and do not get this error.

[TevinAdams]

I had a pickup date 2 days after the latest ghc_diesel_fuel_prices. So my pick-up date was 06-12-2024 and in the DB the latest record had an effective date of 2024-06-04 and an end date of 2024-06-10. This records fuel_price_in_milicents was selected even though the pick up date was after its end date. It looks like in this case it picked the latest. Is that expected? Also how do we get these updated prices? If June 12th is 2 days from now but there is no ghc_diesel_fuel_prices with that date in its range what is that a likely situation and what do we expect to happen in that case?

[deandreJones]

I had a pickup date 2 days after the latest ghc_diesel_fuel_prices. So my pick-up date was 06-12-2024 and in the DB the latest record had an effective date of 2024-06-04 and an end date of 2024-06-10. This records fuel_price_in_milicents was selected even though the pick up date was after its end date. It looks like in this case it picked the latest. Is that expected? Also how do we get these updated prices? If June 12th is 2 days from now but there is no ghc_diesel_fuel_prices with that date in its range what is that a likely situation and what do we expect to happen in that case?

Yes- this is what it should do-
if there isn't a published rate for a pickup date, then it should grab the last published

[TevinAdams]

I changed the pickup date to 06/02/2024 and it chose the ghc fuel price for date range 2020-07-21 - 2020-07-27. Not sure If thats expected.

[danieljordan-caci]

Tested locally and seems good to go. You have some failing tests, but I'd bet they're flaky.

[deandreJones]

I changed the pickup date to 06/02/2024 and it chose the ghc fuel price for date range 2020-07-21 - 2020-07-27. Not sure If thats expected.

if that is the greatest publication date- and your pickup date doesn't fall in any

[TevinAdams]

Tested and worked as expected.

[traskowskycaci]

Replicated your results locally, looks good!