Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runs dep ensure with new fancy but also kind of broken dep #766

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Runs dep ensure with new fancy but also kind of broken dep #766

merged 1 commit into from
Jul 11, 2018

Conversation

stangah
Copy link
Contributor

@stangah stangah commented Jul 11, 2018

Description

Dep changed the way that they they do a vendor verification check (golang/dep#1912), and we always install dep from master in CI, so our pre-tests are failing. This is the new Gopkg.lock using upgraded dep. As of this PR dep ensure is also broken, but dep ensure -v works. Shrug.

Devs will need to upgrade their dep version:
go get -u github.com/golang/dep/cmd/dep

tinyels
tinyels approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@tinyels tinyels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinyels tinyels merged commit 84d7e25 into master Jul 11, 2018
@stangah stangah deleted the ps-dep-dumb branch September 20, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinyels tinyels tinyels approved these changes

@jim jim Awaiting requested review from jim

@chrisgilmerproj chrisgilmerproj Awaiting requested review from chrisgilmerproj

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stangah @tinyels