Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow star-patterns in resource IDs for push/pull #114

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Allow star-patterns in resource IDs for push/pull #114

merged 2 commits into from
Oct 19, 2022

Conversation

kbairak
Copy link
Member

@kbairak kbairak commented Oct 18, 2022 

➜  tx push -staf '*en_*_json'
# Getting info about resources

kb_clitest.en_1_json - Done
kb_clitest.en_2_json - Done
[##############################] (2 / 2)

# Pushing source files

kb_clitest.en_1_json - Done
kb_clitest.en_2_json - Done
[##############################] (2 / 2)

# Pushing translations

kb_clitest.en_1_json [mni] - Done
kb_clitest.en_2_json [mni] - Done
[##############################] (2 / 2)


➜  tx pull -staf '*en_*_json'
# Getting info about resources

kb_clitest.en_1_json - Done
kb_clitest.en_2_json - Done
[##############################] (2 / 2)

# Pulling files

kb_clitest.en_1_json [source] - Done
kb_clitest.en_1_json [mni] - Done
kb_clitest.en_2_json [source] - Done
kb_clitest.en_2_json [mni] - Done
[##############################] (4 / 4)

codegaze
codegaze requested changes Oct 19, 2022
View reviewed changes
Copy link
Member

@codegaze codegaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise @kbairak. Let's please add some documentation and we are good to go. 💪

codegaze
codegaze approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@codegaze codegaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💪

@kbairak kbairak merged commit f5475ff into devel Oct 19, 2022
@kbairak kbairak deleted the resource_ids_star_pattern branch October 19, 2022 07:13
@kbairak kbairak mentioned this pull request Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codegaze codegaze codegaze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbairak @codegaze