Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Poling translations infinite loop fix #201

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Release Poling translations infinite loop fix #201

merged 2 commits into from
Jul 31, 2023

Conversation

foteinigk
Copy link
Contributor

No description provided.

foteinigk and others added 2 commits July 31, 2023 13:57
If downloading translations fails due
to reasons such as the inability to
create the downloaded file
the  "redirect" field in the
response is empty and status is falied
Based on backoff functionality, a request will be retried after
1s, 1s, 1s, 2s, 3s, 5s, 8s, 13s and then after 13s forever
To avoid this we can break the loop if status of task is failed

Remove retries
Copy link

@manos-transifex manos-transifex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@foteinigk foteinigk merged commit 2221ffc into master Jul 31, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants