Add Vue2 Support #105
Merged
Add Vue2 Support #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codegaze
force-pushed
the
add-vuejs2
branch
2 times, most recently
from
aa4ec0c
to
e51d9e3
Compare
In order to parse for phrases the Vue SFC we needed to create a new extract function. This means that cli will also be parsing all the `*.vue` files that will find. `vue-template-compiler` was used to do this so we can extract the different types of content from the Vue template `script` and `template`. For the `template` part we use `compile` to get the AST and we traverse with a custom function and for the `script` we just send to babel. During this implementation it seemed that a lot of code could be extracted from `extract.js` and so a new `parsers` folder was created with `angularHTML`, `vue` and `babel` files with all the functionality that can be reused accross parsers if needed.
n1k0sv
reviewed
Jan 12, 2022
packages/vue2/package.json
Outdated
| }, | ||
| "peerDependencies": { | ||
| "@transifex/native": "^2.1.2", | ||
| "vue": "^2.6.11" |
There was a problem hiding this comment.
Maybe we should put ^2.0.0 for both native and vue?
n1k0sv
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports
<T>,<UT>components,$ttemplate function andtfor script functions. (check more on Readme please) and has aLanguageDropdowncomponent like we do with other frameworks.extract.jsfunction.