Add Messageformat date/time localization support #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1k0sv
force-pushed
the
date-localization
branch
from
2852c60
to
c048e77
Compare
codegaze
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@transifex/native
We were using a single MessageFormat class instance for the entire runtime, defaulting to English locale. This has an issue when trying to use an ICU phrase with dates, e.g.
Date is {d, date, long}.This PR fixes the issue by creating a MessageFormat instance per locale. Now, dates are properly localized internally by the MessageFormat library.
@transifex/cli
Minor improvement to avoid showing the key when it is the same as source in verbose mode
txjs-cli push -v