Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes button for translate selected text is not appear #123

Closed
vitonsky opened this issue Jul 2, 2022 · 3 comments
Closed

Sometimes button for translate selected text is not appear #123

vitonsky opened this issue Jul 2, 2022 · 3 comments
Labels
bug Something isn't working important Must do it

Comments

@vitonsky
Copy link
Collaborator

vitonsky commented Jul 2, 2022

Steps to reproduce:

Expected:

  • Button for translate text will appear

Actual:

  • Button is not appear
@vitonsky vitonsky added the bug Something isn't working label Jul 2, 2022
@vitonsky
Copy link
Collaborator Author

vitonsky commented Jul 2, 2022

Cause may be in ajax navigation. We have to research it

@vitonsky
Copy link
Collaborator Author

vitonsky commented Jul 2, 2022

It's because github re-render whole DOM for this case.

We have to check if root node exists and append it otherwise. And do it always, for each render call

@vitonsky vitonsky added the important Must do it label Jul 2, 2022
vitonsky added a commit that referenced this issue Jul 5, 2022
@vitonsky
fix(#123): re-attach ShadowDOM node to page
fce3436
vitonsky added a commit that referenced this issue Jul 5, 2022
@vitonsky
chore(#123): remove debug print
35663be
@vitonsky
Copy link
Collaborator Author

vitonsky commented Jul 5, 2022

Fixed

@vitonsky vitonsky closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working important Must do it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vitonsky