Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google translator return translated text and original both as translation for some cases #378

Closed
vitonsky opened this issue Jul 7, 2023 · 2 comments · Fixed by #379
Closed
Labels
bug Something isn't working important Must do it

Comments

@vitonsky
Copy link
Collaborator

vitonsky commented Jul 7, 2023

Bug occurs with long text

image

@vitonsky vitonsky added bug Something isn't working important Must do it labels Jul 7, 2023
@offset-torque
Copy link

Although this is a bug, I noticed that it is very useful for language learning. Normally I translate an english page to the language I am learning and read it comparing with the popup (original English).

With this bug I can first read the original sentence in English and then in the language I am learning. This speeds up because I don't need to go up and down between page content and popup.

So maybe this can be implemented as an "inline translation" option if you think other language learners would benefit from it too (and if it is not much effort for you). For example in this case translated text may be bold/different color to differentiate and easy skipping.

By the way, many thanks for this cool extension.

@vitonsky
Copy link
Collaborator Author

vitonsky commented Jul 7, 2023

@offset-torque good idea, i will implement it as opt-in feature, thanks for your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important Must do it
Projects
None yet
2 participants