@uppy/angular: fix Angular version requirement in peerDeps #5067
Conversation
Diff output filesNo diff |
| "@angular/common": "^17.3.0", | ||
| "@angular/core": "^17.3.0", |
There was a problem hiding this comment.
How do we know it doesn't work on both? I was wondering if we postponed this for so long while both might have been possible all along.
There was a problem hiding this comment.
Because we don't test it – and having two Angular examples to test this out seems like more work than it's worth.
There was a problem hiding this comment.
We also don't test 3 React versions but we explicitly support three version ranges. It's not about testing but about expertise about the framework to know how you ship a library for it. What would've been more sensible to me is testing that locally and if it works, we could've just added || ^17.0.0 instead of letting users wait five months before we ship a breaking change.
There was a problem hiding this comment.
I think if someone was proposing this change, with some commitment that they would fix the potential bugs, it would be gladly accepted. Nobody is doing that, and I'm afraid we lack someone in the Uppy team who would be following the Angular project and could make some informed decision regarding whether it would make sense to document support for more versions than the one we test.
| Package | Version | Package | Version | | ------------------------- | ------------ | ------------------------- | ------------ | | @uppy/angular | 0.7.0-beta.2 | @uppy/instagram | 4.0.0-beta.2 | | @uppy/audio | 2.0.0-beta.2 | @uppy/onedrive | 4.0.0-beta.2 | | @uppy/aws-s3 | 4.0.0-beta.2 | @uppy/progress-bar | 4.0.0-beta.2 | | @uppy/aws-s3-multipart | 4.0.0-beta.2 | @uppy/provider-views | 4.0.0-beta.2 | | @uppy/box | 3.0.0-beta.2 | @uppy/react | 4.0.0-beta.2 | | @uppy/companion | 5.0.0-beta.2 | @uppy/remote-sources | 2.0.0-beta.2 | | @uppy/companion-client | 4.0.0-beta.2 | @uppy/screen-capture | 4.0.0-beta.2 | | @uppy/compressor | 2.0.0-beta.2 | @uppy/status-bar | 4.0.0-beta.2 | | @uppy/core | 4.0.0-beta.2 | @uppy/thumbnail-generator | 4.0.0-beta.2 | | @uppy/dashboard | 4.0.0-beta.2 | @uppy/transloadit | 4.0.0-beta.2 | | @uppy/drag-drop | 4.0.0-beta.2 | @uppy/tus | 4.0.0-beta.2 | | @uppy/drop-target | 3.0.0-beta.2 | @uppy/unsplash | 4.0.0-beta.2 | | @uppy/dropbox | 4.0.0-beta.2 | @uppy/url | 4.0.0-beta.2 | | @uppy/facebook | 4.0.0-beta.2 | @uppy/utils | 6.0.0-beta.2 | | @uppy/file-input | 4.0.0-beta.2 | @uppy/webcam | 4.0.0-beta.2 | | @uppy/golden-retriever | 4.0.0-beta.2 | @uppy/zoom | 3.0.0-beta.2 | | @uppy/google-drive | 4.0.0-beta.2 | uppy | 4.0.0-beta.2 | - @uppy/aws-s3: default to multipart depending on the size of input (Antoine du Hamel / #5076) - @uppy/aws-s3: remove deprecated `prepareUploadParts` option (Antoine du Hamel / #5075) - @uppy/core: use variadic arguments for `uppy.use` (Antoine du Hamel / #4888) - @uppy/aws-s3: remove legacy plugin (Antoine du Hamel / #5070) - @uppy/locales: do not build `dist/` folder (Merlijn Vos / #5055) - @uppy/angular: fix Angular version requirement in peerDeps (Antoine du Hamel / #5067) - @uppy/transloadit: remove deprecated options (Merlijn Vos / #5056) | Package | Version | Package | Version | | ---------------- | ------- | ---------------- | ------- | | @uppy/companion | 4.13.1 | uppy | 3.24.1 | | @uppy/file-input | 3.1.1 | | | - @uppy/companion: upgrade redis (Mikael Finstad / #5065) - meta: fix `watch:*` scripts (Antoine du Hamel / #5046) - meta: include more packages in `compare_diff` CI (Antoine du Hamel / #5044) - @uppy/file-input: add missing export (Antoine du Hamel / #5045) - meta: Bump express from 4.18.1 to 4.19.2 in /packages/@uppy/companion (dependabot[bot] / #5036) - @uppy/companion: Bump express from 4.18.1 to 4.19.2 (dependabot[bot] / #5037)
Fixes: #4893 (comment)