-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: enable prettier for markdown #5133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff output filesNo diff |
aduh95
reviewed
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content of this file is quite old, does it make sense to keep it around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss in uppy call 👍
aduh95
approved these changes
May 2, 2024
Murderlon
added a commit
that referenced
this pull request
May 2, 2024
* main: meta: enable prettier for markdown (#5133) @uppy/xhr-upload: do not throw when res is missing url (#5132) @uppy/companion: coerce `requestUrl` to a string (#5128) Release: [email protected] (#5127) meta: enforce use of `.js` extension in `import type` declarations (#5126) @uppy/core: add instance ID to generated IDs (#5080) @uppy/core: reference updated i18n in Restricter (#5118)
Murderlon
added a commit
that referenced
this pull request
May 2, 2024
* 4.x: meta: enable prettier for markdown (#5133) @uppy/xhr-upload: do not throw when res is missing url (#5132) Release: [email protected] (#5130) meta: fix release script Upgrade Yarn to 4.x (#4849) @uppy/companion: coerce `requestUrl` to a string (#5128) Release: [email protected] (#5127) meta: enforce use of `.js` extension in `import type` declarations (#5126) @uppy/core: add instance ID to generated IDs (#5080) @uppy/core: reference updated i18n in Restricter (#5118)
github-actions bot
added a commit
that referenced
this pull request
May 3, 2024
| Package | Version | Package | Version | | ---------------- | ------- | ---------------- | ------- | | @uppy/companion | 4.13.2 | @uppy/xhr-upload | 3.6.6 | | @uppy/core | 3.11.1 | uppy | 3.25.1 | | @uppy/locales | 3.5.3 | | | - @uppy/locales: Update ru_RU locale (Uladzislau Bodryi / #5120) - meta: fix `update-contributors` script (Antoine du Hamel / #5137) - meta: fix `bullet` setting for ReMark (Antoine du Hamel) - meta: add prettier to `.md` pre-commit hooks (Antoine du Hamel) - @uppy/core: make UppyEventMap more readable (Murderlon) - meta: enable prettier for markdown (Merlijn Vos / #5133) - @uppy/xhr-upload: do not throw when res is missing url (Merlijn Vos / #5132) - @uppy/companion: coerce `requestUrl` to a string (Antoine du Hamel / #5128)
This was referenced May 3, 2024
github-actions bot
added a commit
that referenced
this pull request
May 3, 2024
| Package | Version | Package | Version | | ------------------------- | ------------ | ------------------------- | ------------ | | @uppy/audio | 2.0.0-beta.5 | @uppy/progress-bar | 4.0.0-beta.4 | | @uppy/aws-s3 | 4.0.0-beta.3 | @uppy/provider-views | 4.0.0-beta.5 | | @uppy/aws-s3-multipart | 4.0.0-beta.5 | @uppy/react | 4.0.0-beta.5 | | @uppy/box | 3.0.0-beta.5 | @uppy/redux-dev-tools | 4.0.0-beta.2 | | @uppy/companion | 5.0.0-beta.5 | @uppy/remote-sources | 2.0.0-beta.4 | | @uppy/companion-client | 4.0.0-beta.5 | @uppy/screen-capture | 4.0.0-beta.4 | | @uppy/compressor | 2.0.0-beta.5 | @uppy/status-bar | 4.0.0-beta.5 | | @uppy/core | 4.0.0-beta.5 | @uppy/store-default | 4.0.0-beta.2 | | @uppy/dashboard | 4.0.0-beta.5 | @uppy/store-redux | 4.0.0-beta.3 | | @uppy/drag-drop | 4.0.0-beta.4 | @uppy/svelte | 4.0.0-beta.3 | | @uppy/dropbox | 4.0.0-beta.5 | @uppy/thumbnail-generator | 4.0.0-beta.4 | | @uppy/facebook | 4.0.0-beta.5 | @uppy/transloadit | 4.0.0-beta.5 | | @uppy/file-input | 4.0.0-beta.5 | @uppy/tus | 4.0.0-beta.4 | | @uppy/form | 4.0.0-beta.3 | @uppy/unsplash | 4.0.0-beta.5 | | @uppy/golden-retriever | 4.0.0-beta.4 | @uppy/url | 4.0.0-beta.5 | | @uppy/google-drive | 4.0.0-beta.5 | @uppy/utils | 6.0.0-beta.5 | | @uppy/image-editor | 3.0.0-beta.3 | @uppy/vue | 2.0.0-beta.2 | | @uppy/informer | 4.0.0-beta.2 | @uppy/webcam | 4.0.0-beta.5 | | @uppy/instagram | 4.0.0-beta.5 | @uppy/xhr-upload | 4.0.0-beta.3 | | @uppy/locales | 4.0.0-beta.1 | @uppy/zoom | 3.0.0-beta.5 | | @uppy/onedrive | 4.0.0-beta.5 | uppy | 4.0.0-beta.5 | - @uppy/core: make UppyEventMap more readable (Murderlon) - @uppy/audio,@uppy/compressor,@uppy/core,@uppy/dashboard,@uppy/remote-sources,@uppy/tus,@uppy/utils: Format (Murderlon) - @uppy/aws-s3-multipart: Format (Murderlon) - meta: enable prettier for markdown (Merlijn Vos / #5133) - @uppy/xhr-upload: do not throw when res is missing url (Merlijn Vos / #5132) - @uppy/companion: coerce `requestUrl` to a string (Antoine du Hamel / #5128) - meta: enforce use of `.js` extension in `import type` declarations (Antoine du Hamel / #5126) - @uppy/core: add instance ID to generated IDs (Merlijn Vos / #5080) - @uppy/core: reference updated i18n in Restricter (Merlijn Vos / #5118)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have docs in uppy again we want to format them with prettier. I don't see a reason why we wouldn't want to format all markdown so I simply enabled it.