@uppy/core: make getObjectOfFilesPerState more efficient

[Murderlon]

Only one loop instead of many. Ideally we'd have better state management in general, but that's a bigger thing. Tiny improvement for now.

[github-actions]

Diff output files

diff --git a/packages/@uppy/core/lib/Uppy.js b/packages/@uppy/core/lib/Uppy.js
index 7ec8f0f..83a1b27 100644
--- a/packages/@uppy/core/lib/Uppy.js
+++ b/packages/@uppy/core/lib/Uppy.js
@@ -417,22 +417,47 @@ export class Uppy {
       error,
     } = this.getState();
     const files = Object.values(filesObject);
-    const inProgressFiles = files.filter(_ref2 => {
-      let {
+    const inProgressFiles = [];
+    const newFiles = [];
+    const startedFiles = [];
+    const uploadStartedFiles = [];
+    const pausedFiles = [];
+    const completeFiles = [];
+    const erroredFiles = [];
+    const inProgressNotPausedFiles = [];
+    const processingFiles = [];
+    for (const file of files) {
+      const {
         progress,
-      } = _ref2;
-      return !progress.uploadComplete && progress.uploadStarted;
-    });
-    const newFiles = files.filter(file => !file.progress.uploadStarted);
-    const startedFiles = files.filter(file =>
-      file.progress.uploadStarted || file.progress.preprocess || file.progress.postprocess
-    );
-    const uploadStartedFiles = files.filter(file => file.progress.uploadStarted);
-    const pausedFiles = files.filter(file => file.isPaused);
-    const completeFiles = files.filter(file => file.progress.uploadComplete);
-    const erroredFiles = files.filter(file => file.error);
-    const inProgressNotPausedFiles = inProgressFiles.filter(file => !file.isPaused);
-    const processingFiles = files.filter(file => file.progress.preprocess || file.progress.postprocess);
+      } = file;
+      if (!progress.uploadComplete && progress.uploadStarted) {
+        inProgressFiles.push(file);
+        if (!file.isPaused) {
+          inProgressNotPausedFiles.push(file);
+        }
+      }
+      if (!progress.uploadStarted) {
+        newFiles.push(file);
+      }
+      if (progress.uploadStarted || progress.preprocess || progress.postprocess) {
+        startedFiles.push(file);
+      }
+      if (progress.uploadStarted) {
+        uploadStartedFiles.push(file);
+      }
+      if (file.isPaused) {
+        pausedFiles.push(file);
+      }
+      if (progress.uploadComplete) {
+        completeFiles.push(file);
+      }
+      if (file.error) {
+        erroredFiles.push(file);
+      }
+      if (progress.preprocess || progress.postprocess) {
+        processingFiles.push(file);
+      }
+    }
     return {
       newFiles,
       startedFiles,
@@ -1030,11 +1055,11 @@ function _informAndEmit2(errors) {
   const maxNumToShow = 4;
   const firstErrors = userFacingErrors.slice(0, maxNumToShow);
   const additionalErrors = userFacingErrors.slice(maxNumToShow);
-  firstErrors.forEach(_ref3 => {
+  firstErrors.forEach(_ref2 => {
     let {
       message,
       details = "",
-    } = _ref3;
+    } = _ref2;
     this.info(
       {
         message,

[aduh95]

Too bad for readability, but I get why we'd want to do that