Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/docs/Instagram.mdx - rewrite Instagram section #5274

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

lakesare
Copy link
Contributor

@lakesare lakesare commented Jun 25, 2024

This PR

  • moves the Instagram section from CONTRIBUTING.md to uppy.io/docs
    Description of how to set up Instagram oauth doesn't belong to CONTRIBUTING.md - any Uppy user might want to test Instagram locally, not only Uppy contributors.
  • changes the advice to use ngrok to advice to use http://redirectmeto.com
    The issue with ngrok:
    • you need to install ngrok
    • the url changes every time you restart ngrok, which necessitates tinkering with oauth console & .env.
      redirectmeto.com eschews both of these problems.
  • removes "Tester invites" instructions
    Now that Uppy developers have this part covered (our new .env), this part is for outside developers, most of whom will work on this solo - meaning they will never need to think about this part.
    If they do need to consider this part, it's pretty easy to google up, the error message does lead to the solution.

Screenshot

image

Copy link
Contributor

Diff output files
No diff

@lakesare lakesare marked this pull request as ready for review June 25, 2024 07:33
@lakesare lakesare requested a review from Murderlon June 25, 2024 07:34
@aduh95 aduh95 merged commit 8566400 into main Jun 27, 2024
17 checks passed
@aduh95 aduh95 deleted the lakesare/contributing-and-instagram branch June 27, 2024 11:02
github-actions bot added a commit that referenced this pull request Jun 27, 2024
| Package          | Version | Package          | Version |
| ---------------- | ------- | ---------------- | ------- |
| @uppy/dashboard  |   3.9.1 | uppy             |  3.27.1 |
| @uppy/xhr-upload |   3.6.8 |                  |         |

- @uppy/xhr-upload: add `'PATCH'` as valid method (Quinn Daley / #5279)
- @uppy/dashboard: fix handling of `null` for `doneButtonHandler` (Antoine du Hamel / #5283)
- meta: Bump docker/build-push-action from 5.4.0 to 6.1.0 (dependabot[bot] / #5272)
- docs: rewrite Instagram dev setup section (Evgenia Karunus / #5274)
- meta: remove the Zoom section from `CONTRIBUTING.md` (Evgenia Karunus / #5273)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants