Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from yewstack:master #26

Merged
merged 2 commits into from
Apr 13, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Mar 13, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

* fix: hydration of empty VLists

an additional (empty) VText was inserted in the second reconciliation
pass, which tried to insert itself in an invalid position. This internal
error was masked by a "fix" of the internal slot of components, which
should have still been trapped to signal that the second fixup render
was not yet run.

* fixup: new lints from clippy
Copy link

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.787 ns      │ 2.876 ns      │ 2.794 ns      │ 2.797 ns      │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.811 ns      │ 3.369 ns      │ 2.818 ns      │ 2.832 ns      │ 100     │ 1000000000

Copy link

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 308.978 310.311 309.334 0.407
Hello World 10 499.115 509.079 502.685 4.252
Function Router 10 1614.195 1636.899 1621.233 6.970
Concurrent Task 10 1005.662 1006.999 1006.137 0.411
Many Providers 10 1088.612 1142.268 1102.121 15.062

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 308.887 312.010 309.358 0.951
Hello World 10 500.225 513.438 504.399 5.098
Function Router 10 1627.881 1650.097 1634.133 6.552
Concurrent Task 10 1005.601 1007.145 1006.417 0.521
Many Providers 10 1105.104 1145.812 1120.643 11.864

Copy link

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 98.878 98.878 0 0.000%
boids 171.235 171.235 0 0.000%
communication_child_to_parent 91.558 91.558 0 0.000%
communication_grandchild_with_grandparent 103.759 103.759 0 0.000%
communication_grandparent_to_grandchild 99.123 99.123 0 0.000%
communication_parent_to_child 87.866 87.866 0 0.000%
contexts 103.815 103.815 0 0.000%
counter 84.837 84.837 0 0.000%
counter_functional 84.948 84.948 0 0.000%
dyn_create_destroy_apps 87.793 87.793 0 0.000%
file_upload 98.775 98.775 0 0.000%
function_memory_game 169.490 169.490 0 0.000%
function_router 346.023 346.023 0 0.000%
function_todomvc 159.939 159.939 0 0.000%
futures 227.276 227.276 0 0.000%
game_of_life 108.435 108.435 0 0.000%
immutable 188.354 188.354 0 0.000%
inner_html 78.674 78.674 0 0.000%
js_callback 107.197 107.197 0 0.000%
keyed_list 196.837 196.837 0 0.000%
mount_point 81.542 81.542 0 0.000%
nested_list 112.562 112.562 0 0.000%
node_refs 89.066 89.066 0 0.000%
password_strength 1707.740 1707.740 0 0.000%
portals 92.034 92.034 0 0.000%
router 315.273 315.273 0 0.000%
simple_ssr 139.067 139.067 0 0.000%
ssr_router 383.516 383.516 0 0.000%
suspense 113.836 113.836 0 0.000%
timer 87.275 87.275 0 0.000%
timer_functional 96.151 96.151 0 0.000%
todomvc 140.543 140.543 0 0.000%
two_apps 84.233 84.233 0 0.000%
web_worker_fib 133.744 133.744 0 0.000%
web_worker_prime 183.808 183.808 0 0.000%
webgl 81.321 81.321 0 0.000%

✅ None of the examples has changed their size significantly.

@pull pull bot added the ⤵️ pull label Mar 13, 2024
When using complex type constructs in a boxed hook, the compiler could get confused and request a type hint on the call to the inner function.  This adds all generic types of the outer hook function as explicit arguments to the call of the inner function.

* Add generic types to boxed hooks
* Create failing test

---------

Co-authored-by: Michael Meyer <[email protected]>
@pull pull bot merged commit e9739fc into transparencies:master Apr 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants