Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Configurable retry timings for SMF / UPF heartbeats #281

Closed
mgumz opened this issue Dec 30, 2020 · 1 comment · Fixed by #283
Closed

Feature: Configurable retry timings for SMF / UPF heartbeats #281

mgumz opened this issue Dec 30, 2020 · 1 comment · Fixed by #283
Labels
feature 🚀 Feature Request

Comments

@mgumz
Copy link
Contributor

mgumz commented Dec 30, 2020

Between SMF and UPF continuous heartbeat requests are sent to detect availability of the associated UPFs. If these heartbeat requests are not replied in a given time frame, the UPF is considered to be unavailable and thus all the sessions are released.

The timeout value at the moment is hardcoded and rather strict:

ergw/src/ergw_sx_node.erl

Lines 643 to 647 in 09e97cb

send_heartbeat(#data{dp = #node{ip = IP}}) ->
IEs = [#recovery_time_stamp{
time = ergw_gsn_lib:seconds_to_sntp_time(gtp_config:get_start_time())}],
Req = #pfcp{version = v1, type = heartbeat_request, ie = IEs},
ergw_sx_socket:call(IP, 500, 5, Req, response_cb(heartbeat)).

5s for the first timeout
0.5 time out for retries
5 retries

Which makes it like 7.5s to deduce the UPF is not reachable.

For some deployment scenarios that is a really tight deadline to meet.

With a configurable values the situation could be adjusted to the concrete deployment scenario.

@mgumz mgumz added the feature 🚀 Feature Request label Dec 30, 2020
vkatsuba pushed a commit that referenced this issue Jan 12, 2021
vkatsuba pushed a commit that referenced this issue Jan 12, 2021
@vkatsuba
Copy link
Contributor

Closed. Implemented in release 2.8.3.

@vkatsuba vkatsuba linked a pull request Jan 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 Feature Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants