Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Swagger GET metrics #305

Closed
vkatsuba opened this issue Jan 28, 2021 · 1 comment
Closed

Fix Swagger GET metrics #305

vkatsuba opened this issue Jan 28, 2021 · 1 comment
Labels
bug 🐛

Comments

@vkatsuba
Copy link
Contributor

vkatsuba commented Jan 28, 2021 •
edited
Loading

erGW version

2.8.4

Description

Swagger API for get prometheus metrics provide error 404. Looks like the issue in wrong path to endpoint and in wrong accept Content-Type in Swagger config.

Current behavior

When try to call endpoint for get prometheus metrics will be provide error 404 instead of expected metrics data.

Expected behavior

Swagger API for get prometheus metrics should return data of metrics.
@vkatsuba vkatsuba linked a pull request Jan 28, 2021 that will close this issue
Fix Swagger GET metrics #297
Closed
@vkatsuba vkatsuba mentioned this issue Feb 1, 2021
Closed
@vkatsuba
Copy link
Contributor Author

vkatsuba commented Feb 1, 2021

Closed. The /metrics was added into Swagger definitions some time ago and was not working as expected, this issue was fixed, however regarding discussion in #297 was detected that the /metrics should not show in Swagger definitions. Removing of /metrics from Swagger will be done in the scope of #312.

@vkatsuba vkatsuba closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Swagger GET metrics travelping/ergw
1 participant
@vkatsuba