Fix Swagger GET metrics #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
/metrics might not really belong into swagger / API definition. Is not a RPC API, but rather a special function that just happen to be on the same server. Removing /metric from the API specification might be the better approach. @fholzhauser @mgumz opinions? |
|
@RoadRunnr /metrics: yes, should be outside of an api. |
|
Closed PR and opened #313 for delete |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed few issues:
basePathvariable was set base path(/api/v1) for each REST API, while the other REST API can use path without/api/v1application/jsonis not suit for REST API/metrics