Fix issue #133 for correct display of IPv4 and IPv6 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoadRunnr
requested changes
Nov 17, 2020
vkatsuba
force-pushed
the
fix/issue-133
branch
from
d06b465
to
b7c2970
Compare
fholzhauser
approved these changes
Nov 19, 2020
vkatsuba
force-pushed
the
fix/issue-133
branch
from
b7c2970
to
a2e2977
Compare
vkatsuba
force-pushed
the
fix/issue-133
branch
from
a2e2977
to
dd31588
Compare
RoadRunnr
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #133
From the example of task, it can be seen that sometimes, for some reason, the addresses can have binary format like
<<10,65533,126,65533>>etc. which can break the display of the address and will displayed something like<<"\ný~ý">>etc.