Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add miss test case of proxy_lib_SUITE #270

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

vkatsuba
Copy link
Contributor

@vkatsuba vkatsuba commented Nov 25, 2020

Related to #268. Added missing test case in proxy_lib_SUITE and updated configuration for correct checking of ergw_proxy_lib:choose_gw/4 function.

@vkatsuba vkatsuba requested a review from a team November 25, 2020 22:10
@vkatsuba vkatsuba force-pushed the fix/proxy_gw_selection_gw_down-part-2 branch from 74fb204 to ab5db82 Compare November 25, 2020 22:15
Copy link
Contributor

@ebengt ebengt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@RoadRunnr RoadRunnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a guard condition to the wildcard catch in ergw_proxy_lib:choose_gw([], _NodeSelect, _Version, _Socket) would make this more complete.

Added missing test case in proxy_lib_SUITE and updated configuration for correct checking of ergw_proxy_lib:choose_gw/4 function
@vkatsuba vkatsuba force-pushed the fix/proxy_gw_selection_gw_down-part-2 branch from ab5db82 to d4f3c7a Compare November 26, 2020 09:11
@vkatsuba
Copy link
Contributor Author

adding a guard condition to the wildcard catch in ergw_proxy_lib:choose_gw([], _NodeSelect, _Version, _Socket) would make this more complete.

If I got your point correct - done.

Copy link
Member

@RoadRunnr RoadRunnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RoadRunnr RoadRunnr merged commit 1f1b221 into master Nov 27, 2020
@RoadRunnr RoadRunnr deleted the fix/proxy_gw_selection_gw_down-part-2 branch November 27, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants