Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a collection of small fixes #274

Merged
merged 3 commits into from
Dec 9, 2020
Merged

a collection of small fixes #274

merged 3 commits into from
Dec 9, 2020

Conversation

RoadRunnr
Copy link
Member

No description provided.

@RoadRunnr RoadRunnr requested a review from a team as a code owner December 4, 2020 13:10
vkatsuba
vkatsuba suggested changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@vkatsuba vkatsuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like need to fix:

===> src/ergw.erl:48: Warning: ergw:get_node_id/0 is unused export (Xref)
The command "./rebar3 do xref, ct" exited with 1.

@RoadRunnr
OTP 24 socket changes support
2cfd8eb 
OTP socket module is still experimental and TOP-24 brings a backward
incompatible API change.
@RoadRunnr
CT: validate context deletion in GGSN suite
db54129
@RoadRunnr
CT: make IPv4 pool size configurable
6da05b4
@RoadRunnr
Copy link
Member Author

dropped a few cset, most notable the node_id change. That will come as a separate PR.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 78.417% when pulling 6da05b4 on fix/ct into 22d044d on master.

@RoadRunnr RoadRunnr merged commit 40ec096 into master Dec 9, 2020
@RoadRunnr RoadRunnr deleted the fix/ct branch December 9, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkatsuba vkatsuba vkatsuba approved these changes

@fholzhauser fholzhauser fholzhauser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RoadRunnr @coveralls @fholzhauser @vkatsuba