replace context key tupels with records #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkatsuba
approved these changes
Dec 16, 2020
|
Coverage remained the same at 78.329% when pulling c84dc0a2a40d6b4789de4fb8fcb85074d2a44e9e on feature/reg-keys into 22ded94 on master. |
ebengt
approved these changes
Dec 16, 2020
test/ggsn_SUITE.erl
Outdated
| @@ -973,9 +973,10 @@ path_failure() -> | |||
| [{doc, "Check that Create PDP Context works and " | |||
| "that a path failure (Echo timeout) terminates the session"}]. | |||
| path_failure(Config) -> | |||
| CtxKey = #socket_key{name = 'irx', key = {imsi, ?'IMSI', 5}}, | |||
There was a problem hiding this comment.
It might be an idea to define 5 to something more informative.
|
|
||
| {GtpC, _, _} = create_pdp_context(Config), | ||
|
|
||
| {_Handler, Server} = gtp_context_reg:lookup({'irx', {imsi, ?'IMSI', 5}}), | ||
| {_Handler, Server} = gtp_context_reg:lookup(CtxKey), |
There was a problem hiding this comment.
This (1418 + 1422) happens often enough to maybe merit its own function?
Instead of having to count fields in tuples, records allow us to specify matches with the more readable record syntax. They also give us `tagged keys`, that means we can deduce the type of the key from the record tag. This was originally part of the stateless work, but will also be helpful for the cluster registry.
RoadRunnr
force-pushed
the
feature/reg-keys
branch
from
c84dc0a
to
68d4a90
Compare
|
updated, key types are better differentiated now. |
vkatsuba
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having to count fields in tuples, records allow us to
specify matches with the more readable record syntax.
They also give us
tagged keys, that means we can deduce the typeof the key from the record tag.
This was originally part of the stateless work, but will also be
helpful for the cluster registry.