rework context teardown on inactivity to include a proper cause #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework the context inactivity handling to generate a delete GTP message with a related cause (PDP address inactivity timer expire / PDN connection inactivity timer expire).
| Data = close_context(both, up_inactivity_timeout, State, Data0), | ||
| {next_state, shutdown, Data, [{reply, From, {ok, PCtx}}]}; | ||
| State, #{pfcp := PCtx} = Data) -> | ||
| gen_statem:reply(From, {ok, PCtx}), |
There was a problem hiding this comment.
Is there a reason not to return a {reply, ...} value instead of manually replying? Is delete_context already returning something?
If this is the case, I'd prefer result values to calls/casts to be explicitly stated in the body of the appropriate handle_X function. It becomes difficult to follow the messages otherwise.
There was a problem hiding this comment.
- gen_statem does not have a
{reply, ...}return value, it would need a reply action instead delete_context/4is returning{next_state,...}already. Passing{ok, PCtx}into that would need changes to delete_context and I want to keep the changes as local and minimal as possible.
There was a problem hiding this comment.
- Thanks, I was forgetting that it's included in the list of actions.
- Yes, that is the behaviour I don't like :) I'd like to see a explicit action description in the body of the handle_ function. But I agree that this may not be the best case to start working on this.
javiermtorres
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the context inactivity handling to generate a delete GTP
message with a related cause (PDP address inactivity timer expire /
PDN connection inactivity timer expire).