switch session state to stopped after receiving a DIAMETER error #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoadRunnr
force-pushed
the
fix/CENNSO-229/proper-session-stop
branch
from
ee27004
to
286a333
Compare
RoadRunnr
changed the title
RoadRunnr
force-pushed
the
fix/CENNSO-229/proper-session-stop
branch
from
286a333
to
576492f
Compare
ebengt
previously approved these changes
Jan 24, 2023
src/ergw_aaa_rf.erl
Outdated
| @@ -292,7 +292,7 @@ handle_aca(['ACA' | #{'Result-Code' := ?'DIAMETER_BASE_RESULT-CODE_SUCCESS'} = A | |||
| {ok, Session, Events, State}; | |||
| handle_aca([Answer | #{'Result-Code' := Code}], Session, Events, _Opts, State) | |||
| when Answer =:= 'ACA'; Answer =:= 'answer-message' -> | |||
| {{fail, Code}, Session, Events, State}; | |||
| {{fail, Code}, Session, Events, State#state{state = stopped}}; | |||
| handle_aca({error, _} = Result, Session, Events, _Opts, State) -> | |||
There was a problem hiding this comment.
What is different for Rf?
Nasraq set state to stopped for handle_aca({error, _}
Rf does not.
There was a problem hiding this comment.
valid point. I'll rework the change to apply the stop logic only on Requests/Responses that are authorisation related.
Error in Accounting requests (Rf and NASREQ ACR/ACA should IMHO no lead to stop of the session).
This ensures that session do not send termination requests after the session was stopped by a previous error.
RoadRunnr
force-pushed
the
fix/CENNSO-229/proper-session-stop
branch
from
576492f
to
2679944
Compare
vkatsuba
approved these changes
Jan 24, 2023
|
No CCR-T is sent on Gy dialogues failing upon init. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that session do not send termination requests after the session
was stopped by a previous error.