Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ?MODULE to interface names for termination cause errors #95

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Change ?MODULE to interface names for termination cause errors #95

merged 1 commit into from
Dec 8, 2020

Conversation

vkatsuba
Copy link
Contributor

@vkatsuba vkatsuba commented Dec 8, 2020

Based on #85 change ?MODULE to interface names

@vkatsuba vkatsuba mentioned this pull request Dec 8, 2020
Merged
@coveralls
Copy link

coveralls commented Dec 8, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.0005%) to 11.684% when pulling 679e764 on feature/improve_termination_reason_handling_part_2 into 9539ec4 on master.

RoadRunnr
RoadRunnr reviewed Dec 8, 2020
View reviewed changes
Copy link
Member

@RoadRunnr RoadRunnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

would be nice to change the one wrong gy reference at the same time since it is related.

src/ergw_aaa_gx.erl Show resolved Hide resolved
@vkatsuba vkatsuba force-pushed the feature/improve_termination_reason_handling_part_2 branch from 4d95a1e to d784a02 Compare December 8, 2020 16:30
@vkatsuba vkatsuba force-pushed the feature/improve_termination_reason_handling_part_2 branch from d784a02 to 679e764 Compare December 8, 2020 16:31
@vkatsuba vkatsuba merged commit b05b2f5 into master Dec 8, 2020
@vkatsuba vkatsuba deleted the feature/improve_termination_reason_handling_part_2 branch December 8, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoadRunnr RoadRunnr RoadRunnr approved these changes

@fholzhauser fholzhauser Awaiting requested review from fholzhauser

@ebengt ebengt Awaiting requested review from ebengt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkatsuba @coveralls @RoadRunnr