[CENNSO-1522] Collect heap stats in constant time #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for VPP issue: VPP-2092 Rebase of Change: Iaa7a5dda19ce9fd0a32d55f4dd16bc62d4b0b480
demo-exe
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this patch behavior for memory usage metrics and
show memory main-heapwill differ.Metrics collected with fastpath method, which collects less counters, but they collected in constant time.
show memory main-heapkeeps old behavior and will iterate over all allocations. So it can cause lag, and should be used with caution.Fix for VPP issue: VPP-2092
Backport of not yet merged vpp Change: Iaa7a5dda19ce9fd0a32d55f4dd16bc62d4b0b480