Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CENNSO-1670] fix: buffer allocation #49

Merged
merged 1 commit into from
Jul 11, 2024
Merged

[CENNSO-1670] fix: buffer allocation #49

merged 1 commit into from
Jul 11, 2024

Conversation

demo-exe
Copy link
Contributor

@demo-exe demo-exe commented Jul 8, 2024

No description provided.

@demo-exe demo-exe marked this pull request as ready for review July 11, 2024 08:26
@demo-exe demo-exe requested a review from mogaika as a code owner July 11, 2024 08:26
@demo-exe demo-exe changed the title fix: buffer allocation [CENNSO-1670] fix: buffer allocation Jul 11, 2024
@demo-exe demo-exe merged commit 7e61126 into main Jul 11, 2024
3 checks passed
@demo-exe demo-exe deleted the mzyla/upgradefix branch July 11, 2024 08:38
@mogaika
Copy link
Contributor

mogaika commented Jul 19, 2024

Performance hit for // alloc_size |= VLIB_BUFFER_ALIGN; optimization disable when using 1G hugepages and 6400Mhz RAM is around 5% for UPG usecase. It will be little more for usual vpp router usecase. Previous versions haven't had this optimization, so this is not degradation and we can ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogaika mogaika mogaika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demo-exe @mogaika