Fix UPG proxy race conditions for multi core setup #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan4th
reviewed
Nov 9, 2021
| @@ -364,6 +364,12 @@ proxy_start_connect_fn (const u32 * session_index) | |||
|
|
|||
| /* TODO: RACE: should not access the flow on the main thread */ | |||
| flow = pool_elt_at_index (fm->flows, ps->flow_index); | |||
| if (pool_is_free_index (gtm->sessions, flow->session_index)) | |||
There was a problem hiding this comment.
This does not look exactly like a fix, isn't that more of a workaround? The idea which was mentioned in the comment above is that with a separate single worker thread, we should only access the flowable from that worker thread. With multiple workers, things become harder as we have concurrent access to the flowtable from multiple workers. So perhaps we should add a comment that we still have a race here, and create a follow-up issue for proper multithreaded flowtable handling?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #185 and #186