Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: binapi impl for set/get node-id #329

Merged
merged 4 commits into from
May 23, 2023
Merged

feat: binapi impl for set/get node-id #329

merged 4 commits into from
May 23, 2023

Conversation

demo-exe
Copy link
Collaborator

No description provided.

@demo-exe demo-exe requested a review from ivan4th May 18, 2023 15:46
@demo-exe demo-exe changed the title feat: binapi impl for set/get node-id Draft: feat: binapi impl for set/get node-id May 18, 2023
@demo-exe demo-exe marked this pull request as draft May 18, 2023 15:52
@demo-exe demo-exe changed the title Draft: feat: binapi impl for set/get node-id feat: binapi impl for set/get node-id May 18, 2023
ivan4th
ivan4th suggested changes May 18, 2023
View reviewed changes
test/e2e/upg_e2e.go Outdated Show resolved Hide resolved
test/e2e/upg_e2e.go Outdated Show resolved Hide resolved
test/e2e/upg_e2e.go Outdated Show resolved Hide resolved
upf/upf_api.c Outdated Show resolved Hide resolved
upf/upf_api.c Outdated Show resolved Hide resolved
upf/upf_api.c Outdated Show resolved Hide resolved
upf/upf_api.c Outdated Show resolved Hide resolved
upf/upf_api.c Outdated Show resolved Hide resolved
upf/upf_api.c Show resolved Hide resolved
test/e2e/upg_e2e.go Outdated Show resolved Hide resolved
@korroot korroot added the enhancement New feature or request label May 19, 2023
@demo-exe demo-exe marked this pull request as ready for review May 19, 2023 14:10
@demo-exe demo-exe requested a review from ivan4th May 19, 2023 14:10
ivan4th
ivan4th suggested changes May 22, 2023
View reviewed changes
Copy link
Contributor

@ivan4th ivan4th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor quirks in the Go test remaining

test/e2e/upg_e2e.go Outdated Show resolved Hide resolved
test/e2e/upg_e2e.go Outdated Show resolved Hide resolved
test/e2e/upg_e2e.go Outdated Show resolved Hide resolved
test/e2e/upg_e2e.go Outdated Show resolved Hide resolved
test/e2e/upg_e2e.go Outdated Show resolved Hide resolved
test/e2e/upg_e2e.go Outdated Show resolved Hide resolved
test/e2e/upg_e2e.go Outdated Show resolved Hide resolved
upf/upf_api.c Outdated Show resolved Hide resolved
@demo-exe demo-exe requested a review from ivan4th May 22, 2023 15:41
ivan4th
ivan4th approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@ivan4th ivan4th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivan4th ivan4th merged this pull request into master May 23, 2023
@ivan4th ivan4th deleted the mzyla/CENNSO-896 branch May 23, 2023 07:33
@ivan4th ivan4th restored the mzyla/CENNSO-896 branch May 23, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan4th ivan4th ivan4th approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@demo-exe @ivan4th @korroot