switch to UPF specific timer wheel implementation #341
Conversation
time threshold behaves just like time quota, when activate its base must be reset to the last report time.
RoadRunnr
force-pushed
the
feature/upf-timers
branch
from
ffb4b5b
to
c63c7f7
Compare
Import the unmodified version from VPP as basis for future modifications.
RoadRunnr
force-pushed
the
feature/upf-timers
branch
3 times, most recently
from
a32ac79
to
881f5ee
Compare
There was a problem hiding this comment.
One quite small change might be needed, also there's typo in one of the commit descriptions ("stoped"):
Handles must now be allocated before they can be started and they are not
longer automatically freed when stoped. Reusing handles for restarting
or changing timer is now possible.
should be
Handles must now be allocated before they can be started and are no
longer automatically freed when stopped. Reusing handles for restarting
or changing the timer is now possible.
upf/upf_pfcp_server.c
Outdated
| @@ -1368,7 +1308,8 @@ static uword | |||
|
|
|||
| /* run the timing wheel first, to that the internal base for new and updated timers | |||
| * is set to now */ | |||
| upf_pfcp_server_expire_timers (); | |||
| psm->expired = | |||
| TW (tw_timer_expire_timers_vec) (&psm->timer, psm->now, psm->expired); | |||
There was a problem hiding this comment.
psm->expired isn't used outside pfcp_process() anymore, so maybe the expired field could be removed from pfcp_server_main_t and a local var used instead?
RoadRunnr
force-pushed
the
feature/upf-timers
branch
from
881f5ee
to
e979fe7
Compare
|
also fixed the commit message |
There was a problem hiding this comment.
Almost approved, but there's a checkstyle error
Files upf/upf_pfcp_server.c and upf/upf_pfcp_server.c.out2 differ
Checkstyle failed for upf/upf_pfcp_server.c.
Run indent (twice!) as shown to fix the problem:
indent upf/upf_pfcp_server.c
indent upf/upf_pfcp_server.c
*******************************************************************
* VPP CHECKSTYLE FAILED
* CONSULT FAILURE LOG ABOVE
* NOTE: Running 'hack/checkstyle.sh --fix' *MAY* fix the issue
*******************************************************************
make: *** [Makefile:29: checkstyle] Error 1
Decouple memory management for the timer handlers from the start/stop logic. Handles must now be allocated before they can be started and they are no longer automatically freed when stopped. Reusing handles for restarting or changing the timer is now possible. This solves the problem that handles could accidentally reused.
RoadRunnr
force-pushed
the
feature/upf-timers
branch
from
e979fe7
to
35ba369
Compare
Decouple memory management for the timer handlers from the start/stop
logic.
Handles must now be allocated before they can be started and they are no
longer automatically freed when stopped. Reusing handles for restarting
or changing the timer is now possible.
This solves the problem that handles could accidentally reused.