Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: prefix types and functions related to pfcp for consistency #373

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

mogaika
Copy link
Collaborator

@mogaika mogaika commented Jan 8, 2024

Done to clarify usage, to avoid confusion and to not poison global namespace with conflicting names.

Not all kinds of names renamed, since PR already quite large and it would be easy to miss error.
No changes in logic, only renames. Except typedef u32 pfcp_timer_t; was removed, since it was a leftover and proper type was pfcp_timer_ie_t which is now named pfcp_ie_timer_t for consistency.

Example renames:

  • pfcp_node_id_t => pfcp_ie_node_id_t
  • NID_IPv4 => PFCP_NID_IPv4
  • format_ur_seqn => format_pfcp_ie_ur_seqn
  • decode_ur_seqn => decode_pfcp_ie_ur_seqn
  • encode_ur_seqn => encode_pfcp_ie_ur_seqn
  • VENDOR_TRAVELPING => PFCP_VENDOR_TRAVELPING
  • pfcp_session_modification_request_t => pfcp_msg_session_modification_request_t - clarification
  • pfcp_volume_ie_t => pfcp_ie_volume_t - consistency
  • PFCP_HEARTBEAT_REQUEST => PFCP_MSG_HEARTBEAT_REQUEST

@mogaika mogaika marked this pull request as ready for review January 8, 2024 22:33
@mogaika mogaika requested a review from demo-exe as a code owner January 8, 2024 22:33
@mogaika mogaika merged commit 996e0c4 into master Jan 9, 2024
9 checks passed
@mogaika mogaika deleted the feature/reformat-code branch January 9, 2024 11:28
@korroot korroot added the test label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants