Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CENNSO-771] Fix overflow behavior of flowtable and cleanup #375

Merged
merged 5 commits into from
Jan 10, 2024

Conversation

mogaika
Copy link
Collaborator

@mogaika mogaika commented Jan 10, 2024

Remove logic of flow recycle during flow table overflow, since it was broken (crash or hang depending on situation), and also contradicts with NAT case (RFC6888 REQ-11). Also:

  • Remove flow entries per thread cache. It's not needed in new multithreading design
  • Make max flow lifetime to be constant 600 sec, since we do not have api to dynamically change it anyways
  • Use upf_llist intrusive linked list for timers instead of dlist for consistency and clearer interface
  • Change in flow node counters:
    • dropped due to flowtable overflow added
    • flow recycled removed, since we do not recycle flows anymore
    • unhandled (non-ip) packet renamed to more suitable packet without session

@korroot korroot added the fix label Jan 10, 2024
@mogaika mogaika marked this pull request as ready for review January 10, 2024 13:03
upf/flowtable.h Outdated Show resolved Hide resolved
@korroot korroot merged commit a35c710 into master Jan 10, 2024
9 checks passed
@korroot korroot deleted the CENNSO-771/fix-flowtable-overflow branch January 10, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants