[WiP] Add startup script with worker core support #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellonek
reviewed
Feb 9, 2021
start.sh
Outdated
| echo " main-core ${BASH_REMATCH[1]}" >>/tmp/startup.conf | ||
| echo " corelist-workers ${BASH_REMATCH[2]}" >>/tmp/startup.conf | ||
| else | ||
| echo "workers 0" >>/tmp/startup.conf |
| set -o pipefail | ||
| set -o errtrace | ||
|
|
||
| trap "sleep 10" EXIT |
ivan4th
force-pushed
the
feature/multicore-startup-script
branch
2 times, most recently
from
ddde293
to
ea49a88
Compare
There was a corner case of timers "firing" after being stopped because their "user handles" being already collected into the 'expires' vector in pfcp_process(). This caused msg_pool corruption.
Non-empty value of VPP_USE_WORKER_CORE env var enables the use of the worker core. In this case, exactly 2 logical cores must be allocated for the VPP container via the cpuset cgroup controller.
ivan4th
force-pushed
the
feature/multicore-startup-script
branch
from
ea49a88
to
b736a69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-empty value of VPP_USE_WORKER_CORE env var enables the use of the
worker core. In this case, exactly 2 logical cores must be allocated
for the VPP container via the cpuset cgroup controller.
workers 0) case-xfrom#!/bin/bashin thestart.sh