Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vpp-patches: Avoid simple counter overflow #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vpp-patches: Avoid simple counter overflow #91

wants to merge 1 commit into from

Conversation

sergeymatov
Copy link
Contributor

@mgumz
Copy link

mgumz commented Feb 26, 2021

@sergeymatov is this fixing something critical? i can't deduce the impact by reading the commit message.

@sergeymatov
Copy link
Contributor Author

@sergeymatov is this fixing something critical? i can't deduce the impact by reading the commit message.

it's not
we've faced issue with counter overflow once, and tbh - it's just an improvement for counters.
BUT measuring amount of heat around association counter being equal u64_max for a single time, I would suggest that we've never face such thing anymore

@mgumz
Copy link

mgumz commented Feb 26, 2021

what kind of improvement is it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeymatov @mgumz