Convert didTransition to routeDidChange

This fixes this deprecation: https://deprecations-app-prod.herokuapp.com/deprecations/v3.x/#toc_deprecate-router-events
travis-ci · Dec 10, 2018 · 7b90f24 · 7b90f24
1 parent 40bf52a
commit 7b90f24
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/app/router.js b/app/router.js
@@ -1,17 +1,9 @@
-/* global _gaq */
 import EmberRouter from '@ember/routing/router';
 import config from './config/environment';
 
 const Router = EmberRouter.extend({
   location: config.locationType,
   rootURL: config.rootURL,
-
-  didTransition() {
-    this._super(...arguments);
-    if (config.gaCode) {
-      _gaq.push(['_trackPageview', location.pathname]);
-    }
-  }
 });
 
 Router.map(function () {

diff --git a/app/routes/application.js b/app/routes/application.js
@@ -1,4 +1,4 @@
-/* global Travis */
+/* global Travis, _gaq */
 import $ from 'jquery';
 
 import TravisRoute from 'travis/routes/basic';
@@ -22,6 +22,13 @@ export default TravisRoute.extend(BuildFaviconMixin, KeyboardShortcuts, {
     this.get('auth').afterSignOut(() => {
       this.afterSignOut();
     });
+
+    this.router.on('routeDidChange', () => {
+      if (config.gaCode) {
+        _gaq.push(['_trackPageview', location.pathname]);
+      }
+    });
+
     return this._super(...arguments);
   },