Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove help page, replace help link #2922

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

tonoyansergey-devt
Copy link

No description provided.

@tonoyansergey-devt tonoyansergey-devt changed the title Dev/tbt 167 help page Remove help page, replace help link Nov 6, 2024
@tonoyansergey-devt
Copy link
Author

tonoyansergey-devt commented Nov 7, 2024

  • Help page removed and usages removed
  • All explicit definitions of the /help page replaced with travis-ci.com/resources url
  • Created a redirection from /help page to travis-ci.com/resources page
  • Two configurable variables to handle the redirection (example on staging)
Variable Value Description
APP_ENDPOINT app-staging-dev1.travis-ci.com The address of the host from where the redirection will happen. e.g. https://app-staging-dev1.travis-ci.com/help
TRAVIS_HELP_REDIRECT_URL https://www.travis-ci.com/resources/ The target url of redirection

@@ -27,9 +27,9 @@
</div>
<span class="py-1 leading-loose" data-test-manual-subscription-banner='true'>
This manual subscription is paid to Travis CI by bank transfer. If you have any questions or would like to update your plan,
<LinkTo @route='help' @query={{hash anchor='form' billing=true}}>
<ExternalLinkTo @href={{config-get 'urls.resources'}} @title="Travis CI Resources">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where's urls.resources defined?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing part - 09d1721

@@ -249,9 +249,9 @@
<p class="invoice-issue-banner invoice-issue-banner-no-invoices" data-test-help-text='true'>
<SvgImage @name='icon-help' @class='icon-help' />
Having trouble with your invoices?
<LinkTo @route='help' @query={{hash anchor='form' billing=true}}>
<ExternalLinkTo @href={{config-get 'urls.resources'}} @title="Travis CI Resources">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what's rendered here (no urls.resources defined):

We’re happy to help

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing part - 09d1721

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants