New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `travis login` for users with 2fa #454

Merged

rkh merged 2 commits into master from rkh-2fa-login

Nov 22, 2016

Contributor

rkh commented Nov 22, 2016 •

edited

Loading

This pull request does two things:

Use OTP for deleting temporary token, if OTP is expired prompt user for a new on. This fixes the login for any user that has 2fa enabled on GitHub.
If a token with the same note already exists, delete it. This fixes the login command for any user for whom the command previously aborted after creating the token.

See https://github.com/travis-pro/team-teal/issues/1456


          GitHub login: use OTP for deleting token, handle token already existi…

a294be8

…ng due perviously failing login attempt

rkh added the in progress label


          remove commented out code

325ffd8

rkh merged commit 1dd7da6 into master

rkh deleted the rkh-2fa-login branch

November 22, 2016 16:49

rkh removed the in progress label

This was referenced Nov 22, 2016

Can't login with multifactor authentication #448

Closed

Cannot login with username/password #453

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet