-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix swap memory permission and gracefully handle permission errors #150
Merged
alexdelprete
merged 5 commits into
travisghansen:main
from
Snuffy2:Gracefully-handle-permission-errors
Sep 5, 2024
Merged
Fix swap memory permission and gracefully handle permission errors #150
alexdelprete
merged 5 commits into
travisghansen:main
from
Snuffy2:Gracefully-handle-permission-errors
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Snuffy2
commented
Sep 4, 2024
•
edited
Loading
edited
- Use different swap memory endpoint that works with current permissions
- Gracefully handle errors, especially permission errors and show this in the Error text
- Add more type hints and annotations
While you're preparing this, could you check this line? the |
Snuffy2
force-pushed
the
Gracefully-handle-permission-errors
branch
from
September 4, 2024 22:41
a42a1a9
to
71083dc
Compare
You went back to |
Yes, for testing the errors. Not final. |
Snuffy2
force-pushed
the
Gracefully-handle-permission-errors
branch
from
September 5, 2024 02:01
9a311ce
to
1a137d5
Compare
Snuffy2
force-pushed
the
Gracefully-handle-permission-errors
branch
from
September 5, 2024 02:03
1a137d5
to
7c13141
Compare
Looks good, I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.