Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swap memory permission and gracefully handle permission errors #150

Merged

Conversation

Snuffy2
Copy link
Collaborator

@Snuffy2 Snuffy2 commented Sep 4, 2024

  • Use different swap memory endpoint that works with current permissions
  • Gracefully handle errors, especially permission errors and show this in the Error text
  • Add more type hints and annotations

@alexdelprete
Copy link
Collaborator

alexdelprete commented Sep 4, 2024

While you're preparing this, could you check this line? the memory variable looks undefined (it's defined in the line after)

@Snuffy2 Snuffy2 force-pushed the Gracefully-handle-permission-errors branch from a42a1a9 to 71083dc Compare September 4, 2024 22:41
@alexdelprete
Copy link
Collaborator

You went back to pfstates vs pf_states?

@Snuffy2
Copy link
Collaborator Author

Snuffy2 commented Sep 5, 2024

You went back to pfstates vs pf_states?

Yes, for testing the errors. Not final.

@Snuffy2 Snuffy2 force-pushed the Gracefully-handle-permission-errors branch from 9a311ce to 1a137d5 Compare September 5, 2024 02:01
@Snuffy2 Snuffy2 force-pushed the Gracefully-handle-permission-errors branch from 1a137d5 to 7c13141 Compare September 5, 2024 02:03
@Snuffy2 Snuffy2 marked this pull request as ready for review September 5, 2024 02:06
@alexdelprete
Copy link
Collaborator

Looks good, I'll merge it.

@alexdelprete alexdelprete merged commit 59137c6 into travisghansen:main Sep 5, 2024
2 checks passed
@Snuffy2 Snuffy2 deleted the Gracefully-handle-permission-errors branch September 5, 2024 21:41
@Snuffy2 Snuffy2 added the bugfix Fix something that isn't working label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix something that isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants