Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move HA services from entity level to platform level #204

Conversation

Snuffy2
Copy link
Collaborator

@Snuffy2 Snuffy2 commented Sep 20, 2024

  • Made it so that the entity is no longer needed if there is only 1 OPNsense Router
  • Added UI details to all services
  • Improved descriptions
  • Stops using the deprecated hass.helpers.service
  • For the OPNsense service actions (fka. services), will accept service_id or service_name (but not both in a single call). No matter which one is used, it will actually work if the item is a Service ID or a Service Name. service_id is now shown as the default, but service_name will continue to work so previous automations, etc. should continue to work.

Should be released with #206

@Snuffy2 Snuffy2 added the enhancement Enhancing existing functionality label Sep 20, 2024
@Snuffy2 Snuffy2 force-pushed the Move-entity-services-to-platform-services branch 7 times, most recently from 01202af to 7df61ae Compare September 22, 2024 15:30
Added UI details to all services
Improved descriptions
@Snuffy2 Snuffy2 force-pushed the Move-entity-services-to-platform-services branch from 7df61ae to 7b29b74 Compare September 23, 2024 00:07
@Snuffy2 Snuffy2 marked this pull request as ready for review September 23, 2024 01:17
@alexdelprete
Copy link
Collaborator

alexdelprete commented Sep 23, 2024

Should be released with #206

Do we want to release a beta first, with #204 and #206?

I see a check failing.

@Snuffy2
Copy link
Collaborator Author

Snuffy2 commented Sep 23, 2024

I believe the failing check is an issue with hassfest: home-assistant/core#126467

Beta would probably be good for at least a couple of others to try it out before a broad release.

@alexdelprete alexdelprete merged commit ef25472 into travisghansen:main Sep 23, 2024
1 of 2 checks passed
@Snuffy2 Snuffy2 deleted the Move-entity-services-to-platform-services branch September 24, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancing existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants