Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate and rename filesystem sensors #262

Merged

Conversation

Snuffy2
Copy link
Collaborator

@Snuffy2 Snuffy2 commented Oct 15, 2024

Requires #258 First

  • Moves from using the device to the mountpoint as the unique_id to prevent filesystem sensor duplicates being created with firmware updates for some users.
  • Removes the _slash_ naming convention and just uses a _ instead.

@Snuffy2 Snuffy2 added enhancement Enhancing existing functionality bugfix Fix something that isn't working labels Oct 15, 2024
@Snuffy2 Snuffy2 force-pushed the Migrate-and-Rename-Filesystem-Sensors branch from 04c9499 to ee3deed Compare October 16, 2024 01:10
@Snuffy2 Snuffy2 marked this pull request as ready for review October 16, 2024 21:53
@Snuffy2
Copy link
Collaborator Author

Snuffy2 commented Oct 16, 2024

@alexdelprete it would be great if you could try this yourself before it goes out to see if it causes any issues/duplicates for you. A beta would be fine.

@alexdelprete alexdelprete merged commit add4386 into travisghansen:main Oct 17, 2024
2 checks passed
@alexdelprete
Copy link
Collaborator

@alexdelprete it would be great if you could try this yourself before it goes out to see if it causes any issues/duplicates for you. A beta would be fine.

Tested now, this is the old entity:

image

Replaced with this one:

image

Seems to be working fine.

@Snuffy2 Snuffy2 deleted the Migrate-and-Rename-Filesystem-Sensors branch October 17, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix something that isn't working enhancement Enhancing existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants