Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use deprecated units #182

Closed

Conversation

MattyRoy
Copy link

@MattyRoy MattyRoy commented Jan 9, 2024

Many of the units from Home Assistant are deprecated and will be removed in 2025.1 - this pull request moves away from the deprecated units.

@epenet
Copy link

epenet commented Jan 9, 2024

Ha! I just discovered this PR. I didn't see it when I created mine as #183
The only thing I would suggest on this PR is to run isort to ensure the imports are ordered correctly.

@MattyRoy
Copy link
Author

MattyRoy commented Jan 9, 2024

Thanks, I have pushed the changes after run isort!

Copy link

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, fixes #178

@epenet
Copy link

epenet commented Jan 30, 2024

@travisghansen it would be good to be rid of these warnings.
The new constants have been available for a few years already...

@travisghansen
Copy link
Owner

Thanks for the contribution! I didn't see this until I already updated them. Try the latest version and if I missed something let's open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants