Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

digdag init should set default timezone #31

Closed
danielnorberg opened this issue Apr 11, 2016 · 2 comments
Closed

digdag init should set default timezone #31

danielnorberg opened this issue Apr 11, 2016 · 2 comments

Comments

@danielnorberg
Copy link
Contributor

$ digdag --version
0.5.9
$ digdag init foo
2016-04-11 14:42:38 -0700: Digdag v0.5.9
  Creating foo/digdag
  Creating foo/.digdag-wrapper/digdag.jar
  Creating foo/.gitignore
  Creating foo/tasks/shell_sample.sh
  Creating foo/tasks/repeat_hello.sh
  Creating foo/tasks/__init__.py
  Creating foo/digdag.yml
Done. Type `cd foo` and `./digdag r` to run the workflow. Enjoy!
$ cd foo
$ digdag push foo -r test
2016-04-11 14:42:52 -0700: Digdag v0.5.9
Creating digdag.archive.tar.gz...
Exception in thread "main" io.digdag.client.config.ConfigException: timezone: parameter is required but not set at digdag.yml. Example is 'timezone: America/Los_Angeles'.
    at io.digdag.cli.client.Archive.runArchive(Archive.java:152)
    at io.digdag.cli.client.Archive.archive(Archive.java:105)
    at io.digdag.cli.client.Push.push(Push.java:66)
    at io.digdag.cli.client.Push.mainWithClientException(Push.java:41)
    at io.digdag.cli.client.ClientCommand.main(ClientCommand.java:55)
    at io.digdag.cli.Main.main(Main.java:176)
@frsyuki
Copy link
Member

frsyuki commented Apr 12, 2016

I still wonder whether timezone should be included in workflow definition or not...
If a workflow is intended to be shared by other workflows as a library, the workflow shouldn't have timezone. So, applications and libraries have different requirements.
Right now, digdag push requires you to put timezone config in the config file. This is useful when you can't restrict who deploys your workflow to production. Another idea is that digdag push requires --timezone option.

@frsyuki
Copy link
Member

frsyuki commented Apr 20, 2016

workflow.yml includes timestamp: UTC since 0.7.0.

@frsyuki frsyuki closed this as completed Apr 20, 2016
yoyama added a commit that referenced this issue Jun 24, 2022
* Add tests for schedulers.
* Update DailySchedulerTest
yoyama added a commit that referenced this issue Jun 24, 2022
* Add  tests in schedulers (#31)
* Add start/end in schedule (#32)

Implement start/end in daily>, hourly>, minutes_interval>, monthly> and weekly>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants