Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport API enhancement #1697

Merged
merged 4 commits into from
Feb 17, 2022
Merged

Backport API enhancement #1697

merged 4 commits into from
Feb 17, 2022

Conversation

yoyama
Copy link
Contributor

@yoyama yoyama commented Jan 24, 2022

Backporting API enhancement in TD. Add following parameters.

  • GET /api/workflows supports name_pattern parameter to search by workflow name. (partial match).
  • GET /api/projects supports name_pattern parameter to search by project name. (partial match).
  • GET /api/projects supports count and last_id to change number of return and pagination like /api/workflows.
  • Due to difference in ProjectResource.getProjects() implementation, re-implement the modification for GET /api/projects.

These changes do not affect default behavior of APIs.

@yoyama yoyama requested a review from szyn January 25, 2022 01:52
@yoyama yoyama marked this pull request as ready for review January 25, 2022 02:28
Copy link
Member

@szyn szyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yoyama yoyama merged commit 83136d6 into master Feb 17, 2022
@szyn szyn deleted the backport-api-enhance branch April 15, 2022 07:44
@yoyama yoyama added this to the v0.10.5 milestone Apr 18, 2022
chezou added a commit to chezou/tdworkflow that referenced this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants