Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump HikariCP deps and keepaliveTime configurable #1702

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Bump HikariCP deps and keepaliveTime configurable #1702

merged 1 commit into from
Jul 8, 2022

Conversation

szyn
Copy link
Member

@szyn szyn commented Feb 1, 2022

  1. Bump HikariCP to 4.0.3 (Current Java 8 maven artifact)
  2. Make keepaliveTime configurable (the config was introduced in 4.0.0)

According to README, keepaliveTime is useful in the following cases 👍

This property controls how frequently HikariCP will attempt to keep a connection alive, in order to prevent it from being timed out by the database or network infrastructure.

@szyn szyn marked this pull request as ready for review April 15, 2022 04:21
@yoyama yoyama self-requested a review April 15, 2022 07:54
@yoyama
Copy link
Contributor

yoyama commented Jul 8, 2022

@szyn If no concern, let's merge it.

@szyn szyn added this to the v0.10.5 milestone Jul 8, 2022
@szyn
Copy link
Member Author

szyn commented Jul 8, 2022

👍

@szyn szyn merged commit 8e3a53d into master Jul 8, 2022
@szyn szyn deleted the upgrade-HikariCP-4_0_3 branch July 8, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyama yoyama yoyama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.10.5
Development

Successfully merging this pull request may close these issues.
2 participants
@szyn @yoyama